-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: packages/alice_objectbox #205
Conversation
I've merged UI refactor PR. Please rebase :) |
|
I'll try to implement all the changes from your fork into mine. ⏳ |
Yeah it's dirty solution, just wanted to show some PoC. Feel free to remove duplicated code. |
@jhomlala OK, I've merged all your stuff with mine and I think it now looks good. Run over it once you can and let me know it you have more feedback. |
I don't want to block this PR, it looks good, but I'm thinking about unit tests (at least for storages) and updating docs. What do you think? Thank you so much for this hard work. |
Unit testing storage will be quite labor intensive, as you have to create a local ObjectBox on the runner, i.e. a macOS binary etc. It's all well documented on ObjectBox's website ... but still a PITA to set up. 🙈 I'd rather make driver tests, but then you have to run simulators, compile the thing and play it on a sim in Github Actions + mock an HTTP server because you don't wanna DDoS anyone 🤪 #fun The documentation is for the most part there in the example. Not sure if there should be any more readmes etc. I can add some more stuff, if needed. |
Sure, I understand. We can do it in separate PR. I'm thinking about doing unit tests for things that we can do, for example memory storage. For hard stuff - we can do integration tests. For documentation I was thinking about adding info about storage here: https://github.com/jhomlala/alice/blob/master/docs/config.md. Well I think we can merge it, but I keep looking for some tests - we're getting more and more logic. |
I added some more docs. |
@techouse Are you still working on this PR? |
Just fixed a bug 🐛 should be all good now |
Hmm, I was just thinking whether all the add / remove etc methods should be async. Waiting for them synchronously is quite a pain, i.e. FutureOr<void> addCall(AliceHttpCall call);
FutureOr<void> addError(AliceHttpError error, int requestId);
FutureOr<void> addResponse(AliceHttpResponse response, int requestId);
FutureOr<void> addHttpCall(AliceHttpCall aliceHttpCall);
FutureOr<void> removeCalls(); Maybe in a new PR. This one is too big already :D |
@jhomlala let me know if you're happy with this PR. Then we can start tackling other stuff. |
This PR adds the ability to store all the
AliceHttpCall
s in an ObjectBoxBox
via a package.How to get started
Caveats
Addresses #156