fix/wrong-navigator-used: _onBackPressed use the wrong navigator. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g custom it will pop the wrong page
EArminjon
commented
Sep 26, 2024
| @@ -17,7 +17,7 @@ class AliceGeneralDialog { | |||
| }) => | |||
| showDialog<void>( | |||
| context: context, | |||
| builder: (BuildContext buildContext) { | |||
| builder: (BuildContext context) { | |||
There was a problem hiding this comment.
Without that, the wrong context is pop (the parent one) and instead of dialog pop we got root navigation pop...
|
Hello, any update ? |
jhomlala
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_onBackPressed use rootNavigator: true.
When using
alice.setNavigatorKey(navigatorKey)the code usingusing rootNavigator: truewill use the root navigator of the app instead of the one gave from setNavigatorKey. That lead to some black screen (because root page removed) or wrong root removal.This property should be removed as this PR did.