-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rxdart dependency to 0.28.0 in alice package #235
Conversation
@@ -267,7 +267,9 @@ class _AliceCallsListPageState extends State<AliceCallsListPage> | |||
? context.i18n(AliceTranslationKey.saveSuccessView) | |||
: null, | |||
secondButtonAction: () => | |||
OperatingSystem.isAndroid ? OpenFilex.open(result.path) : null, | |||
OperatingSystem.isAndroid && result.path != null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be part of this PR and is already being addressed in #229
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! Do we know when this will be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "this"? 😅 This PR here or #229?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally both, but I meant this specific PR. Sorry for not being specific. 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per issue #234 , I've taken the time to create a PR for this. Let me know if there's anything else I should address if this is something that will be merged.