Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap to 0.4.0 #49

Open
4 of 7 tasks
seankross opened this issue Aug 29, 2023 · 4 comments
Open
4 of 7 tasks

Roadmap to 0.4.0 #49

seankross opened this issue Aug 29, 2023 · 4 comments
Assignees

Comments

@seankross
Copy link
Collaborator

seankross commented Aug 29, 2023

  • get rid of text2speech specific code
  • specify/document voice engine API (Improve function documentation #57)
  • generally reduce number of arguments in functions (especially relating to ffmpeg)
  • write a vignette about what kinds of args to pass to ffmpeg
  • See if the burning subtitles functions work.
  • Should write some new tests for Ari that use tts coqui since it's free. A really cool test would go from tts to stt. (likely these only get run locally and not on cran)

Bonus:

  • spin out ariExtra functions into separate utility packages
@seankross
Copy link
Collaborator Author

 function(images, paragraphs,
                     output = tempfile(fileext = ".mp4"),
                     voice_engine = seantalk::talk,
                     subtitles = FALSE,
                     duration = NULL,
                     engine_args = list(helium = TRUE, service = "seanbox"),
                     key_or_json_file = NULL,
                     ...)


                     
wav <- do.call(voice_engine, args = engine_args)
# check that it's a list with a named object called wav that contains a tuneR::Wave
wav <- reduce(wav$wav, bind)
wav <- pad_wav(wav, duration = duration[i])

@howardbaik howardbaik self-assigned this Aug 29, 2023
@howardbaik
Copy link
Contributor

howardbaik commented Aug 29, 2023

@cansavvy This is a roadmap of the next release of ari that came out of my meeting with Sean.

@howardbaik howardbaik changed the title Roadmap to 0.4 Roadmap to 0.4.0 Aug 30, 2023
@howardbaik
Copy link
Contributor

howardbaik commented Aug 30, 2023

I documented the relationship between the main ari functions here

@cansavvy
Copy link
Contributor

cansavvy commented Sep 1, 2023

I'm super excited about this. But I think since I wasn't in the meeting these bullet points lead me to more questions than me understanding the roadmap. Would love to meet with everyone involved to chat and divide up tasks/roles for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants