Migrate functions to ari #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 2, 2023 14:58
|
Honestly, my thought is, we leave ariExtra be. I don't want to mess up people who are using it, but I also don't want to promise to maintain it either. Thoughts, @howardbaek ? |
|
I just thought it'd be repetitive to have the same functions in two different packages, but also don't mind leaving ariExtra as is. Maybe @muschellij2 has thoughts? |
|
It is a bit repetitive and not ideal, but I don't want to throw anyone off who is using this package. I think we just move slowly to make it so ariExtra is no longer an additional dependency requirement but as for ariExtra itself, I think we leave it alone so we know we aren't actively disrupting any projects that use it. Does this make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved a few functions inside ari. For the ariExtra functions that rely on the functions that I moved, I used the
ari::function()syntax to keep them from failing. When I randevtools::document(), it seems like the vignette is failing to build, so might have to look at it later.