copy over cow function to ottrpal #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kweav
commented
Jul 9, 2024
| @@ -23,6 +23,7 @@ export(get_gs_pptx) | |||
| export(get_image_from_slide) | |||
| export(get_image_link_from_slide) | |||
| export(get_object_id_notes) | |||
| export(get_pages_url) | |||
There was a problem hiding this comment.
Do I need to also add an @export to the make_screenshots() function?
kweav
commented
Jul 9, 2024
R/get_pages_url.R
Outdated
| #' | ||
| #' usethis::create_github_token() | ||
| #' | ||
| #' get_chapters("jhudsl/Documentation_and_Usability") |
There was a problem hiding this comment.
Does this example need updated?
cansavvy
approved these changes
Jul 9, 2024
R/get_pages_url.R
Outdated
| #' | ||
| #' usethis::create_github_token() | ||
| #' | ||
| #' get_chapters("jhudsl/Documentation_and_Usability") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in code review for PR #153 and various issues (#137 and jhudsl/cow#27) -- Tried to copy over the
cow::get_pages_url()function so that it's usable without needing to importcow.I used
wgetto get the raw file for theget_pages_url()function from thecowrepo and useddevtools::document()after that. Removed references tocowwithin themake_screenshots()function.