Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this more compatible #39

Open
alexppg opened this issue Mar 14, 2020 · 5 comments
Open

Make this more compatible #39

alexppg opened this issue Mar 14, 2020 · 5 comments

Comments

@alexppg
Copy link

alexppg commented Mar 14, 2020

Hi
I was trying to use this awesome project with plain docker (docker compose, actually) and I couldn't do it. Peeking the code I saw this conditional https://github.com/jimmidyson/configmap-reload/blob/master/configmap-reload.go#L166. Could we get rid of it? I understand that is done because k8s mount it's volumes with that notation, but It would be very useful to use this outside k8s.

@alexppg
Copy link
Author

alexppg commented Jul 24, 2020

Ping.

@alexppg
Copy link
Author

alexppg commented Sep 9, 2020

I've done it in this fork. https://github.com/little-angry-clouds/configmap-reload

@jimmidyson
Copy link
Owner

hey @alexppg! Feel free to submit a PR for review.

@william-tran
Copy link

+1 I have a shared volume that's being updated by a sidecar, so removing that configmap-only condition would be helpful.

@alexppg
Copy link
Author

alexppg commented Dec 28, 2021

@william-tran In the meanwhile, you may want to use this. It's the images generated from my PR.

simonpasquier pushed a commit to simonpasquier/configmap-reload that referenced this issue Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants