Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostpath Mount not working #79

Open
whitepiratebaku opened this issue Oct 11, 2022 · 6 comments
Open

Hostpath Mount not working #79

whitepiratebaku opened this issue Oct 11, 2022 · 6 comments

Comments

@whitepiratebaku
Copy link

Hello, is it supposed to work with HostPath mount from node? because it does not seem to work.

@jimmidyson
Copy link
Owner

Hmm that's an interesting one. This will not work because the strategy expects the volume to be mounted in the way that a configmap (or secret) is mounted (see https://github.com/jimmidyson/configmap-reload/blob/main/configmap-reload.go#L183).

@whitepiratebaku
Copy link
Author

Yeah, thank you

@alitari
Copy link

alitari commented Mar 12, 2023

@jimmidyson ok, but what is the reason behind this restriction to "..data" ? Wouldn't it simply work with all kind of data sources ( persistent volumes , etc.) if we skip this restriction?

@jimmidyson
Copy link
Owner

Originally this was only for configmaps, which work with this ..data strategy, and I can't remember the reason why I enforced this restriction 😅

@jimmidyson
Copy link
Owner

Thinking about this, the inotify notification required would be different for a hostpath volume or persistentvolume mount, in that what are we watching: the mounted directory, or content in the mounted directory? For configmaps, watching ..data only makes sense as the directory symlink is updated which makes what we're watching much easier. To have more generic support, we would need to think about what we do support and what the UX would be.

@alitari
Copy link

alitari commented Mar 13, 2023

i understand, thx for the explanation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants