Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 도서 상태 정보를 청구기호 순으로 정렬 #549

Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Aug 18, 2023

개요

image

기타

https://github.com/jiphyeonjeon-42/backend/blob/bfbb03c68601f812bf43763e9c0544c9907853fc/backend/src/v1/books/books.service.ts#L397

처음부터 백엔드에서 돌려줄 때 청구기호 순으로 정렬해 돌려주는 것도 좋을 것 같습니다.

@scarf005 scarf005 linked an issue Aug 18, 2023 that may be closed by this pull request
@scarf005 scarf005 marked this pull request as draft August 18, 2023 06:57
@scarf005 scarf005 force-pushed the 531-도서-상태정보를-청구기호-순으로-정렬 branch from 4912d48 to e021244 Compare August 18, 2023 07:40
@scarf005 scarf005 marked this pull request as ready for review August 18, 2023 08:32
<BookStatus key={book.id} book={book} index={index} />
))}
{bookDetailInfo.books
?.toSorted((a, b) => compareCallsign(a, b))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

낯선 메서드라 찾아보니 ECMA 2023이네요!
최신 문법 활용 역시 👍
덕분에 새로 배웠습니다!

@scarf005 scarf005 force-pushed the 531-도서-상태정보를-청구기호-순으로-정렬 branch from e021244 to 796ac44 Compare September 20, 2023 05:10
@scarf005 scarf005 merged commit 1b5c241 into develop Sep 20, 2023
5 checks passed
@scarf005 scarf005 deleted the 531-도서-상태정보를-청구기호-순으로-정렬 branch September 20, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

도서 상태정보를 청구기호 순으로 정렬
2 participants