fix: limit the length of the pipeline description

jippi · Sep 11, 2024 · 1fe94c5 · 1fe94c5
1 parent 7e12fd1
commit 1fe94c5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 22 deletions.
diff --git a/go.mod b/go.mod
@@ -35,6 +35,7 @@ require (
 
 require (
 	github.com/agnivade/levenshtein v1.1.1 // indirect
+	github.com/aquilax/truncate v1.0.0 // indirect
 	github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
 	github.com/bahlo/generic-list-go v0.2.0 // indirect
 	github.com/buger/jsonparser v1.1.1 // indirect

diff --git a/go.sum b/go.sum
@@ -4,6 +4,8 @@ github.com/agnivade/levenshtein v1.1.1 h1:QY8M92nrzkmr798gCo3kmMyqXFzdQVpxLlGPRB
 github.com/agnivade/levenshtein v1.1.1/go.mod h1:veldBMzWxcCG2ZvUTKD2kJNRdCk5hVbJomOvKkmgYbo=
 github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883 h1:bvNMNQO63//z+xNgfBlViaCIJKLlCJ6/fmUseuG0wVQ=
 github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883/go.mod h1:rCTlJbsFo29Kk6CurOXKm700vrz8f0KW0JNfpkRJY/8=
+github.com/aquilax/truncate v1.0.0 h1:UgIGS8U/aZ4JyOJ2h3xcF5cSQ06+gGBnjxH2RUHJe0U=
+github.com/aquilax/truncate v1.0.0/go.mod h1:BeMESIDMlvlS3bmg4BVvBbbZUNwWtS8uzYPAKXwwhLw=
 github.com/arbovm/levenshtein v0.0.0-20160628152529-48b4e1c0c4d0 h1:jfIu9sQUG6Ig+0+Ap1h4unLjW6YQJpKZVmUzxsD4E/Q=
 github.com/arbovm/levenshtein v0.0.0-20160628152529-48b4e1c0c4d0/go.mod h1:t2tdKJDJF9BV14lnkjHmOQgcvEKgtqs5a1N3LNdJhGE=
 github.com/aymanbagabas/go-osc52/v2 v2.0.1 h1:HwpRHbFMcZLEVr42D4p7XBqjyuxQH5SMiErDT4WkJ2k=

diff --git a/pkg/scm/gitlab/client.go b/pkg/scm/gitlab/client.go
@@ -11,6 +11,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/aquilax/truncate"
 	"github.com/hasura/go-graphql-client"
 	"github.com/jippi/scm-engine/pkg/scm"
 	"github.com/jippi/scm-engine/pkg/state"
@@ -214,7 +215,7 @@ func (client *Client) Stop(ctx context.Context, evalError error, allowPipelineFa
 			status = go_gitlab.Failed
 		}
 
-		description = scm.TruncateText(evalError.Error(), 250)
+		description = truncate.Truncate(evalError.Error(), 250, "...", truncate.PositionEnd)
 	}
 
 	_, response, err := client.wrapped.Commits.SetCommitStatus(state.ProjectID(ctx), state.CommitSHA(ctx), &go_gitlab.SetCommitStatusOptions{

diff --git a/pkg/scm/helpers.go b/pkg/scm/helpers.go
@@ -5,7 +5,6 @@ import (
 	"path/filepath"
 	"regexp"
 	"strings"
-	"unicode"
 )
 
 // Ptr is a helper that returns a pointer to v.
@@ -75,26 +74,6 @@ func FindModifiedFiles(files []string, patterns ...string) []string {
 	return output
 }
 
-func TruncateText(text string, maxLen int) string {
-	lastSpaceIx := maxLen
-	curLen := 0
-
-	for i, r := range text {
-		if unicode.IsSpace(r) {
-			lastSpaceIx = i
-		}
-
-		curLen++
-
-		if curLen > maxLen {
-			return text[:lastSpaceIx] + "..."
-		}
-	}
-
-	// If here, string is shorter or equal to maxLen
-	return text
-}
-
 // buildPatternRegex compiles a new regexp object from a gitignore-style pattern string
 func buildPatternRegex(pattern string) (*regexp.Regexp, error) {
 	// Handle specific edge cases first