Skip to content

Commit

Permalink
fix: emit 'skip' for external pipeline on failure
Browse files Browse the repository at this point in the history
we do not want to block the ability to merge code due to a scm-engine failure
  • Loading branch information
jippi committed Sep 4, 2024
1 parent cb49713 commit 486bae3
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions pkg/scm/gitlab/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,13 +210,7 @@ func (client *Client) Stop(ctx context.Context, evalError error) error {
)

if evalError != nil {
status = go_gitlab.Failed

// If the evaluation failed due to no config file, consider it a "skip" instead
if strings.Contains(evalError.Error(), "404 Not Found") {
status = go_gitlab.Skipped
}

status = go_gitlab.Skipped
message = evalError.Error()
}

Expand Down

0 comments on commit 486bae3

Please sign in to comment.