Profile comparison - Waypoints Table #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlebod
force-pushed
the
profile-comparison
branch
from
75bab08 to
762f1ce
Compare
jirkapok
reviewed
Dec 5, 2023
| {{ row.depthA | number: '1.0-0'}} | ||
| </td> | ||
| <td *ngIf="row.durationA !== undefined else emptyRowWithDivider" class="px-1 vertical-right-border"> | ||
| {{ row.durationA * 1000 | date: 'mm:ss'}} |
There was a problem hiding this comment.
We have dynamic duration formatting based on the value, see original component
There was a problem hiding this comment.
Will fix once importing profiles into DiveSchedules is implemented
projects/planner/src/app/diff/waypoints/diff-waypoints.component.ts
Outdated
Show resolved
Hide resolved
projects/planner/src/app/diff/waypoints/diff-waypoints.component.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| ngOnInit(): void { | ||
| const MAX_SAFETY_LIMIT = 65536; // 2**16 |
There was a problem hiding this comment.
Keep component empty. It should contain only logic related to rendering.
Introduce new service, which will prepare data for this component and make it testable.
See e.g. https://github.com/jirkapok/GasPlanner/blob/master/projects/planner/src/app/shared/waypoints.service.spec.ts
There was a problem hiding this comment.
For now simply extracted to a Provider class. Will rework into injectable service once importing testing profiles into DiveSchedule is implemented.
xlebod
force-pushed
the
profile-comparison
branch
from
762f1ce to
e7b10ef
Compare
added 22 commits
January 6, 2024 17:32
xlebod
force-pushed
the
profile-comparison
branch
from
7c51ce9 to
e86946f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.