Dive Results dashboard

[xlebod]

• Take data from services instead of TestData class
• Add example data injection
• Add Dive Results table

[github-actions]

Test Results

  2 files  ±0    2 suites  ±0   2s ⏱️ ±0s
828 tests +2  490 ✅ ±0  338 💤 +2  0 ❌ ±0 
831 runs  +2  490 ✅ ±0  341 💤 +2  0 ❌ ±0 

Results for commit bbbf2f9. ± Comparison against base commit ad0f2b6.

♻️ This comment has been updated with latest results.

[jirkapok]

move as much as out of the html.

[jirkapok]

Profile B cant be second profile, because it is not guaranteed to exist. By default there is only one dive.
Proposal: set 0 for both.

[jirkapok]

btw. services are singletons, e.g. after you remove dive from dives list and navigate to the diff, you need to ensure, that previously selected index still exists and this cant be done in constructor, since it is called only once. You need to do it in component OnInit, e.g. , if there are at least 2 select A=0, B=1, if index is out of range reset to 0. So you can leave 0 for both A and B while initializing.

[xlebod]

btw. services are singletons, e.g. after you remove dive from dives list and navigate to the diff, you need to ensure, that previously selected index still exists and this cant be done in constructor, since it is called only once. You need to do it in component OnInit, e.g. , if there are at least 2 select A=0, B=1, if index is out of range reset to 0. So you can leave 0 for both A and B while initializing.

Setting of indexes will be done in the upcoming ProfileSelectorTabs component. For now the out of range was handled in diff.component.html which wouldn't render the diff page unless at least 2 profiles were created. But I've removed that and implemented proposed change above.