Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Dive Comparison development #5

Merged
merged 45 commits into from
Mar 12, 2024
Merged

Finish Dive Comparison development #5

merged 45 commits into from
Mar 12, 2024

Conversation

xlebod
Copy link
Collaborator

@xlebod xlebod commented Mar 12, 2024

  • Add Gas Consumed dashboard
  • Replace placeholder Profile Chart dashboard with working one
  • Minor UI changes
  • Changes to file structure and file names

Denis Lebo added 30 commits February 29, 2024 14:40
Add skeleton of selection tabs for diff
4da7209
Add color toggling when button clicked
3e849c3
Make DiveResults accessor functions into getters
0cc503e
Move setter to be after getters
082abf0
Transform profileIndexes into Observables
f0cb5e7
Implement profile selection with buttons
f40521b
Add color separation between profile A/B
99fbe26
Add waypoint filter todo
c4043c3
Rework buttons to have headers for Profile A/B
9b74411
Use title for diff selector buttons
2c527a7
Add animation module import to .spec.ts
7d6566d
Add dive.title to all dashboards
f65aa43
Use white font on primary color for contrast
401f9fc
Rename diveinfo directory to diveresults
e2cc4a4
Rename all diff-diveinfo files to diff-diveresults
91201bc
Rename class names from DiveInfo to DiveResults
5106765
Rename diff/diveresults/results folder to */table
3db914c
Rename diff-diveresults-results to *-table
902d401
Rename class names from DiveResultsResults.. to DiveResultsTable..
191553f
Paste original profile-chart code into diff
52b7633
Extract plot methods into chartPlotter
fea025c
Add providers to test
2d1c9eb
Extract all variable values into class variables
b40f54e
Update graph on change of Profile A index
16090bc
Implement Factory pattern for chartPlotter
a56bfb6
Wait with 1st render until profiles calculated
f583a4a
Add Profile B to profile chart
3d685af
Hook chart events after profiles are calculated
637c58b
Add Gas Consumed component skeleton
fee1250
Add safety reserve bar
23b2df4
@github-actions GitHub Actions
Copy link

Test Results

  2 files  ±0    2 suites  ±0   14s ⏱️ -11s
883 tests +4  883 ✅ +4  0 💤 ±0  0 ❌ ±0 
886 runs  +4  886 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit b28a2c3. ± Comparison against base commit 3e189be.

@jirkapok jirkapok merged commit 7b8d44a into develop Mar 12, 2024
2 checks passed
@jirkapok jirkapok deleted the profile-comparison branch March 12, 2024 23:54
@xlebod xlebod restored the profile-comparison branch May 20, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xlebod @jirkapok