Miscellaneous fixes and cleanup #24

ebatsell · 2024-03-04T17:20:11Z

Fixes a number of small things including:

Potential for self invocation of CopyGossipContactInfo to overwrite real values
Reading data offsets in CopyGossipContactInfo rather than hardcoding assumed offsets
Potential epoch overflow for cast epoch
Comments around how specific structs and instructions are intended to work
Shifting epoch_start_timestamp to avoid overwriting existing bytes and avoid trimming data type

programs/validator-history/src/instructions/copy_gossip_contact_info.rs

programs/validator-history/src/utils.rs

ebatsell added 9 commits March 4, 2024 12:16

Miscellaneous fixes

ce0a139

clippylint

080e647

..

fbc9330

..

34206f2

update mio

2999b2e

idl

c2dce1c

?

e01229e

finally

cfd218c

fix indexing math

20b28e8

buffalu reviewed Mar 4, 2024

View reviewed changes

programs/validator-history/src/instructions/copy_gossip_contact_info.rs Show resolved Hide resolved

buffalu reviewed Mar 4, 2024

View reviewed changes

programs/validator-history/src/utils.rs Show resolved Hide resolved

buffalu reviewed Mar 4, 2024

View reviewed changes

programs/validator-history/src/utils.rs Show resolved Hide resolved

add test for ed25519 check

76723a3

buffalu approved these changes Mar 5, 2024

View reviewed changes

ebatsell merged commit 5d9cc66 into master Mar 5, 2024
6 checks passed

ebatsell deleted the evan/misc-fixes branch March 5, 2024 21:38

Provide feedback