Fixes: rebalance decrease amount calculation, validator_lamport_balance initialization, tweaks to keeper #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebatsell
force-pushed
the
evan/rebalance-validator-list
branch
from
16a0751
to
1e703e2
Compare
CoachChuckFF
suggested changes
Aug 6, 2024
| @@ -245,6 +252,7 @@ impl UnstakeState { | |||
| // either to the target or to the previous balance before the deposit, whichever is lower in terms of total lamports unstaked | |||
| if current_lamports > state.validator_lamport_balances[index] | |||
| && self.stake_deposit_unstake_total < self.stake_deposit_unstake_cap | |||
| && state.validator_lamport_balances[index] != LAMPORT_BALANCE_DEFAULT | |||
There was a problem hiding this comment.
Do we want the same check for increase_stake_calculation?
There was a problem hiding this comment.
the increase_stake_calculation algo here doesn't interact with this field so we're safe
| @@ -967,15 +967,6 @@ impl StewardState { | |||
| RebalanceType::None | |||
| }; | |||
|
|
|||
| msg!("Reserve lamports after adjustment: {}", reserve_lamports); | |||
There was a problem hiding this comment.
was causing local tests to fail since it was calling msg! outside of context, + think we're okay to remove these now since we have the emits
| self.validator_lamport_balances[index] = self.validator_lamport_balances[index] | ||
| .checked_add(amount) | ||
| .ok_or(StewardError::ArithmeticError)?; | ||
| if self.validator_lamport_balances[index] != LAMPORT_BALANCE_DEFAULT { |
There was a problem hiding this comment.
Do we want this same check for Decrease?
ebatsell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
rebalanceinstruction when there are no activating or deactivating lamports and then continue with the working process. Adds a sentinel value and checks to skip modifying it when sentinel is present.