feat(config): Make the packet timeline configurable. #2163
Conversation
|
I'm a little concerned what happens to packets that are in flight at the moment the timeline gets turned on. Maybe restructure it so that |
|
The timeline is configurable in the config file but once initialized doesn't change (payload verification does, via an http api). I just renamed |
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt
Outdated
Show resolved
Hide resolved
| @@ -56,7 +58,7 @@ class EventTimeline( | |||
| } | |||
|
|
|||
| fun clone(): EventTimeline { | |||
| val clone = EventTimeline(ConcurrentLinkedQueue(timeline)) | |||
| val clone = EventTimeline(timeline.toMutableList()) | |||
There was a problem hiding this comment.
Not a new bug, but while you're in there, clone() should pass clock rather than letting it default to Clock.systemUTC().
| private val clock: Clock = Clock.systemUTC() | ||
| ) : Iterable<Pair<String, Duration>> { | ||
|
|
||
| private val timeline: MutableList<Pair<String, Duration>> = Collections.synchronizedList(timelineArg) |
There was a problem hiding this comment.
This shouldn't need the type
No description provided.