fix(JingleSession) Remove ice restart option and functionality. #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinvite method in Jicofo is set to restart-jingle (terminate and recreate the whole jingle session) instead of sending 'transport-replace'. The replaceTransport option has never worked because of a bug in Chrome related to TCC sequence numbering after the DTLS transport layer is reset to start a new DTLS handshake with fresh transport on the bride.
bgrozev
reviewed
Oct 10, 2024
| @@ -255,40 +249,6 @@ export default class JingleConnectionPlugin extends ConnectionPlugin { | |||
| this.eventEmitter.emit(XMPPEvents.CALL_ENDED, sess, reasonCondition, reasonText); | |||
| break; | |||
| } | |||
| case 'transport-replace': { | |||
There was a problem hiding this comment.
Suggest adding a log that transport-replace in not supported, just to help people debug if it happens to be used somehow
damencho
approved these changes
Oct 11, 2024
|
Can you remind me of the upstream issue number? Agree that the general behavior after a DTLS restart is pretty underspecified but maybe we can at least get the TWCC sequence number clarified :-) |
Sure, here it is - https://issues.webrtc.org/issues/42222276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinvite method in Jicofo is set to restart-jingle (terminate and recreate the whole jingle session) instead of sending 'transport-replace'. The replaceTransport option has never worked because of a bug in Chrome related to TCC sequence numbering after the DTLS transport layer is reset to start a new DTLS handshake with fresh transport on the bride.