Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return_types and new abstraction for requests to be made #110

Merged
merged 26 commits into from
Feb 18, 2024

Conversation

jjjermiah
Copy link
Owner

  • needs rigorous testing

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (86621f1) 82.41% compared to head (6874a3d) 80.57%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/nbiatoolkit/dicomsort/dicomsort.py 18.64% 48 Missing ⚠️
src/nbiatoolkit/nbia.py 81.65% 20 Missing ⚠️
src/nbiatoolkit/utils/parsers.py 75.00% 6 Missing ⚠️
tests/test_nbia_series_functions.py 97.46% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   82.41%   80.57%   -1.84%     
==========================================
  Files          19       22       +3     
  Lines        1211     1179      -32     
==========================================
- Hits          998      950      -48     
- Misses        213      229      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjjermiah jjjermiah merged commit f943a05 into main Feb 18, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant