Fixing the test logic

jkueh · Dec 3, 2020 · d88f45e · d88f45e
1 parent 6e7cbda
commit d88f45e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/util_test.go b/util_test.go
@@ -3,24 +3,24 @@ package main
 import "testing"
 
 func TestEmptyOTP(t *testing.T) {
-	if valid, err := oneTimePasscodeIsValid(""); err != nil {
-		t.Errorf("Empty OTP triggered error: %s", err)
+	if valid, err := oneTimePasscodeIsValid(""); err == nil {
+		t.Errorf("Empty OTP triggered did not trigger error as expected: %s", err)
 	} else if valid {
 		t.Errorf("Empty OTP passed validation")
 	}
 }
 
 func TestAlphabetOTP(t *testing.T) {
-	if valid, err := oneTimePasscodeIsValid("hunter2"); err != nil {
-		t.Errorf("Invalid (alphabetical) OTP triggered error: %s", err)
+	if valid, err := oneTimePasscodeIsValid("hunter2"); err == nil {
+		t.Errorf("Invalid (alphabetical) OTP did not trigger error as expected: %s", err)
 	} else if valid {
 		t.Errorf("Invalid (alphabetical) OTP passed validation")
 	}
 }
 
 func TestShortOTP(t *testing.T) {
-	if valid, err := oneTimePasscodeIsValid("42069"); err != nil {
-		t.Errorf("Invalid (short) OTP threw error: %s", err)
+	if valid, err := oneTimePasscodeIsValid("42069"); err == nil {
+		t.Errorf("Invalid (short) OTP did not trigger error as expected: %s", err)
 	} else if valid {
 		t.Errorf("Invalid (short) OTP passed validation")
 	}