Review ConsolePrompt's method visibilities

[mattirn]

1. ConsolePrompt do not implement AutoCloseable
2. Create open() method that set terminal in raw mode (the last four statement of the constructor)
3. enclose prompt methods
   1. public Map<String, PromptResultItemIF> prompt(List<AttributedString> header, List<PromptableElementIF> promptableElementList) and
   2. public Map<String, PromptResultItemIF> prompt(List<AttributedString> headerIn, Function<Map<String, PromptResultItemIF>, List<PromptableElementIF>> promptableElementLists)

code with "open() - close()" i.e.

    public Map<String, PromptResultItemIF> prompt(...) throws IOException {
        try {
            open();
            ....
            ....
            return resultMap;
        } finally {
            close();
        }
    }

4. remove @Deprecated statements
5. review ConsolePrompt's other methods visibilities
6. fix examples

[quintesse]

Ok, so if I understand this correctly this would roll back the change that made ConsolePrompt AutoCloseable?

If so another improvement might be introduce a subclass of ConsolePrompt that does implement AutoCloseable and that handles the open/close for you.

And perhaps (but I haven't thought it through a 100% yet) we would not even need a (public) open() necessarily, thereby maintaining full backward compatibility with older code (but we'd advise people to switch to the newer, improved, AutoCloseable version of ConsolePrompt)

WDYT?