Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"serve export" exports layout directory #58

Open
Rocketpilot opened this issue Nov 14, 2011 · 6 comments
Open

"serve export" exports layout directory #58

Rocketpilot opened this issue Nov 14, 2011 · 6 comments

Comments

@Rocketpilot
Copy link

From the examples I've seen, and from the default project you get when you run "serve create project", the best practice seems to be to create a /views/layouts/default.html.erb file for the overall page layout. When you come to export the project to html, a /layouts/default.html file is also exported. Changing the file-name to _defaults.html.erb prevents this from happening, but it kind of feels like a weird and unexpected extra step to have to go to in order to create a clean export.

I think either the docs need to clarify what's going on here, or the export function should treat the /layouts/ folder as special in some way, regardless of what the files inside are named.

@Rocketpilot
Copy link
Author

Addendum: here's a nice, live, example of the problem: http://get-serve.com/layouts/default.html

@ntalbott
Copy link
Contributor

ntalbott commented Apr 6, 2012

Huh, interesting. @jlong any opinion on this? I don't really like the idea of making the layouts directory special, but maybe we could allow dropping a "crumb" in a directory to indicate it shouldn't be exported?

@jlong
Copy link
Owner

jlong commented Apr 6, 2012

A .serve-ignore file?

@ntalbott
Copy link
Contributor

ntalbott commented Apr 6, 2012

So one approach would be a top-level file (like .serve-ignore) that specifies globs. Another (simpler) approach would be to allow dropping a .no-export file in a directory to have it not be exported.

@jlong
Copy link
Owner

jlong commented Apr 6, 2012

Either's fine with me.

@ghost ghost assigned ntalbott Apr 7, 2012
@jlong
Copy link
Owner

jlong commented Feb 23, 2013

I like the .no-export idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants