Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty configs shouldn't break the panel #27

Open
jmc-88 opened this issue Jun 7, 2017 · 0 comments
Open

Empty configs shouldn't break the panel #27

jmc-88 opened this issue Jun 7, 2017 · 0 comments
Assignees
@jmc-88
Labels
bug

Comments

@jmc-88
Copy link
Owner

jmc-88 commented Jun 7, 2017

Default values for all configuration attributes should be provided, so that an empty configuration file doesn't result in a crash or in an unusable panel. Right now, if no panel_size is provided, Launcher::GetIconSize() will return 0 and cause Launcher::Resize() to abort the program with SIGFPE.
@jmc-88 jmc-88 self-assigned this Jun 7, 2017
@jmc-88 jmc-88 added the bug label Jun 7, 2017
jmc-88 added a commit that referenced this issue Jun 7, 2017
@jmc-88
Enforce panel size > 0
d715bba 
If this assumption fails, Bad Things™ will happen.

Related issues:
  - #27
jmc-88 added a commit that referenced this issue Jun 7, 2017
@jmc-88
Default launcher size to panel size
67ec1c6 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: rename UpdateNetWMStrut, make it member
90f8047 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: introduce new config
2fac212 
Currently unused. Fields will be migrated piecemeal.

Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: move mouse-related fields to new config
dcfbd05 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: move size-related fields to new config
c0c5859 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: move monitor number field to new config
e7aaa3c 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
Fix test code following latest commits
7ee55d9 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: move padding fields to new config
39cef55 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: move margin fields to new config
42d580b 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: move background field to new config
5d25b51 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 20, 2017
@jmc-88
panel: move battery field to new config
77523a4 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 21, 2017
@jmc-88
panel: move panel_layer field to new config
27b0ea5 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 21, 2017
@jmc-88
panel: move panel_mode field to new config
87bc1bc 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 21, 2017
@jmc-88
panel: move wm_menu field to new config
70d5139 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 21, 2017
@jmc-88
panel: move panel_dock field to new config
5f32913 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 24, 2017
@jmc-88
panel: move panel_horizontal field to new config
e3830fc 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move panel_autohide field to new config
2b52cd9 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move p_a_show_timeout field to new config
8426eba 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move p_a_hide_timeout field to new config
460409d 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move p_autohide_height field to new config
e624ccb 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move panel_strut_policy field to new config
0caa7aa 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move vertical_position field to new config
3a1a0a0 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move horizontal_position to new config
413efc7 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move panel_items_order field to new config
703d334 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Sep 25, 2017
@jmc-88
panel: move max_tick_urgent field to new config
7b4bbc7 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move mouse actions fields to new config
a40a295 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: use non-static data member initialization
e9fc6c6 
Cleaner way to provide default values. Move initialization to the constructor
and remove the need for a PanelConfig::Default() initializer.

Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
tooltip: use non-static data member initialization
879d62e 
Cleaner way to provide default values. Remove constructor,
TooltipConfig::Default() initializer, and turn class into a struct.

Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: rename UpdateNetWMStrut, make it member
98941ba 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: introduce new config
d7fe686 
Currently unused. Fields will be migrated piecemeal.

Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move mouse-related fields to new config
cdecda9 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move size-related fields to new config
b3bdb59 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move monitor number field to new config
e2e504e 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
Fix test code following latest commits
972cecd 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move padding fields to new config
60a9d5e 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move margin fields to new config
2539e90 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move background field to new config
c2c7cd1 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move battery field to new config
8109ba1 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move panel_layer field to new config
37ae8d1 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move panel_mode field to new config
fdf54a6 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move wm_menu field to new config
f9d138f 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move panel_dock field to new config
d0c4298 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move panel_horizontal field to new config
99c66cb 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move panel_autohide field to new config
f856a50 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move p_a_show_timeout field to new config
a9a16c2 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move p_a_hide_timeout field to new config
441e495 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move p_autohide_height field to new config
22ba77f 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move panel_strut_policy field to new config
8892968 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move vertical_position field to new config
89aa116 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move horizontal_position to new config
315f78c 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move panel_items_order field to new config
4c72e0b 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move max_tick_urgent field to new config
195b09b 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: move mouse actions fields to new config
9aa4099 
Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
panel: use non-static data member initialization
aff6227 
Cleaner way to provide default values. Move initialization to the constructor
and remove the need for a PanelConfig::Default() initializer.

Related issues:
  - #27
jmc-88 added a commit that referenced this issue Oct 1, 2017
@jmc-88
tooltip: use non-static data member initialization
5893be2 
Cleaner way to provide default values. Remove constructor,
TooltipConfig::Default() initializer, and turn class into a struct.

Related issues:
  - #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmc-88 jmc-88

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmc-88