Merge pull request galaxyproject#18740 from guerler/remove_pair_creator

Remove Build Dataset Pair option from history actions
jmchilton · Aug 28, 2024 · 5452c14 · 5452c14
2 parents fb4d5be + f297497
commit 5452c14
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 23 deletions.
diff --git a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js
@@ -211,23 +211,18 @@ describe("History Selection Operations", () => {
 
             it("should display collection building options only on active (non-deleted) items", async () => {
                 const buildListOption = '[data-description="build list"]';
-                const buildPairOption = '[data-description="build pair"]';
                 const buildListOfPairsOption = '[data-description="build list of pairs"]';
                 await wrapper.setProps({ filterText: "visible:true deleted:false" });
                 expect(wrapper.find(buildListOption).exists()).toBe(true);
-                expect(wrapper.find(buildPairOption).exists()).toBe(true);
                 expect(wrapper.find(buildListOfPairsOption).exists()).toBe(true);
                 await wrapper.setProps({ filterText: "deleted:true" });
                 expect(wrapper.find(buildListOption).exists()).toBe(false);
-                expect(wrapper.find(buildPairOption).exists()).toBe(false);
                 expect(wrapper.find(buildListOfPairsOption).exists()).toBe(false);
                 await wrapper.setProps({ filterText: "visible:any deleted:false" });
                 expect(wrapper.find(buildListOption).exists()).toBe(true);
-                expect(wrapper.find(buildPairOption).exists()).toBe(true);
                 expect(wrapper.find(buildListOfPairsOption).exists()).toBe(true);
                 await wrapper.setProps({ filterText: "deleted:any" });
                 expect(wrapper.find(buildListOption).exists()).toBe(false);
-                expect(wrapper.find(buildPairOption).exists()).toBe(false);
                 expect(wrapper.find(buildListOfPairsOption).exists()).toBe(false);
             });
 

diff --git a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue
@@ -37,9 +37,6 @@
             <b-dropdown-item v-if="showBuildOptions" data-description="build list" @click="buildDatasetList">
                 <span v-localize>Build Dataset List</span>
             </b-dropdown-item>
-            <b-dropdown-item v-if="showBuildOptions" data-description="build pair" @click="buildDatasetPair">
-                <span v-localize>Build Dataset Pair</span>
-            </b-dropdown-item>
             <b-dropdown-item v-if="showBuildOptions" data-description="build list of pairs" @click="buildListOfPairs">
                 <span v-localize>Build List of Dataset Pairs</span>
             </b-dropdown-item>
@@ -385,9 +382,6 @@ export default {
 
             this.buildNewCollection("list", allContents);
         },
-        async buildDatasetPair() {
-            await this.buildNewCollection("paired");
-        },
         async buildListOfPairs() {
             await this.buildNewCollection("list:paired");
         },

diff --git a/lib/galaxy_test/selenium/test_collection_builders.py b/lib/galaxy_test/selenium/test_collection_builders.py
@@ -32,18 +32,6 @@ def test_build_list_and_show_items(self):
         self.collection_builder_create()
         self._wait_for_hid_visible(3)
 
-    @selenium_test
-    @managed_history
-    def test_build_pair_simple_hidden(self):
-        self.perform_upload(self.get_filename("1.tabular"))
-        self.perform_upload(self.get_filename("2.tabular"))
-        self._wait_for_and_select([1, 2])
-        self._collection_dropdown("build pair")
-        self.collection_builder_set_name("my awesome pair")
-        self.screenshot("collection_builder_pair")
-        self.collection_builder_create()
-        self._wait_for_hid_visible(5)
-
     @selenium_test
     @managed_history
     def test_build_paired_list_simple(self):