From 44caba7bed059884b343680b3431bff0a71f4238 Mon Sep 17 00:00:00 2001 From: guerler Date: Tue, 27 Aug 2024 08:42:27 +0300 Subject: [PATCH 1/3] Remove Build Dataset Pair option from history actions --- .../HistoryOperations/SelectionOperations.vue | 6 ------ 1 file changed, 6 deletions(-) diff --git a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue index a7c5224de617..fca63e70dd68 100644 --- a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue +++ b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue @@ -37,9 +37,6 @@ Build Dataset List - - Build Dataset Pair - Build List of Dataset Pairs @@ -385,9 +382,6 @@ export default { this.buildNewCollection("list", allContents); }, - async buildDatasetPair() { - await this.buildNewCollection("paired"); - }, async buildListOfPairs() { await this.buildNewCollection("list:paired"); }, From 726c1edbdcda06a85214ca05e137a5b78c95b42f Mon Sep 17 00:00:00 2001 From: guerler Date: Tue, 27 Aug 2024 11:49:34 +0300 Subject: [PATCH 2/3] Adjust selection operation test --- .../HistoryOperations/SelectionOperations.test.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js index 80d187842094..de5c632e5b2e 100644 --- a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js +++ b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js @@ -211,23 +211,18 @@ describe("History Selection Operations", () => { it("should display collection building options only on active (non-deleted) items", async () => { const buildListOption = '[data-description="build list"]'; - const buildPairOption = '[data-description="build pair"]'; const buildListOfPairsOption = '[data-description="build list of pairs"]'; await wrapper.setProps({ filterText: "visible:true deleted:false" }); expect(wrapper.find(buildListOption).exists()).toBe(true); - expect(wrapper.find(buildPairOption).exists()).toBe(true); expect(wrapper.find(buildListOfPairsOption).exists()).toBe(true); await wrapper.setProps({ filterText: "deleted:true" }); expect(wrapper.find(buildListOption).exists()).toBe(false); - expect(wrapper.find(buildPairOption).exists()).toBe(false); expect(wrapper.find(buildListOfPairsOption).exists()).toBe(false); await wrapper.setProps({ filterText: "visible:any deleted:false" }); expect(wrapper.find(buildListOption).exists()).toBe(true); - expect(wrapper.find(buildPairOption).exists()).toBe(true); expect(wrapper.find(buildListOfPairsOption).exists()).toBe(true); await wrapper.setProps({ filterText: "deleted:any" }); expect(wrapper.find(buildListOption).exists()).toBe(false); - expect(wrapper.find(buildPairOption).exists()).toBe(false); expect(wrapper.find(buildListOfPairsOption).exists()).toBe(false); }); From f2974970b46dc928699cc835126ec6694bd43780 Mon Sep 17 00:00:00 2001 From: guerler Date: Tue, 27 Aug 2024 19:39:20 +0300 Subject: [PATCH 3/3] Remove pair selenium test --- lib/galaxy_test/selenium/test_collection_builders.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/lib/galaxy_test/selenium/test_collection_builders.py b/lib/galaxy_test/selenium/test_collection_builders.py index 1ef184dec3f6..24b47a825cf3 100644 --- a/lib/galaxy_test/selenium/test_collection_builders.py +++ b/lib/galaxy_test/selenium/test_collection_builders.py @@ -32,18 +32,6 @@ def test_build_list_and_show_items(self): self.collection_builder_create() self._wait_for_hid_visible(3) - @selenium_test - @managed_history - def test_build_pair_simple_hidden(self): - self.perform_upload(self.get_filename("1.tabular")) - self.perform_upload(self.get_filename("2.tabular")) - self._wait_for_and_select([1, 2]) - self._collection_dropdown("build pair") - self.collection_builder_set_name("my awesome pair") - self.screenshot("collection_builder_pair") - self.collection_builder_create() - self._wait_for_hid_visible(5) - @selenium_test @managed_history def test_build_paired_list_simple(self):