Merge pull request #27 from mvdbeek/guerler-new_toolshed

Remove handle_panel_update

lib/galaxy/tools/__init__.py

@@ -242,16 +242,6 @@ def __init__(self, config_filenames, tool_root_dir, app):
             app=app,
         )
 
-    def handle_panel_update(self, section_dict):
-        """
-        Sends a panel update to all threads/processes.
-        """
-        send_control_task(self.app, 'create_panel_section', kwargs=section_dict)
-        # The following local call to self.create_section should be unnecessary
-        # but occasionally the local ToolPanelElements instance appears to not
-        # get updated.
-        self.create_section(section_dict)
-
     def has_reloaded(self, other_toolbox):
         return self._reload_count != other_toolbox._reload_count
 

lib/galaxy/tools/toolbox/base.py

@@ -98,13 +98,6 @@ def __init__(self, config_filenames, tool_root_dir, app):
             self._load_tool_panel()
         self._save_integrated_tool_panel()
 
-    def handle_panel_update(self, section_dict):
-        """Extension-point for Galaxy-app specific reload logic.
-
-        This abstract representation of the toolbox shouldn't have details about
-        interacting with the rest of the Galaxy app or message queues, etc....
-        """
-
     def create_tool(self, config_file, tool_shed_repository=None, guid=None, **kwds):
         raise NotImplementedError()
 
@@ -264,7 +257,7 @@ def get_section(self, section_id, new_label=None, create_if_needed=False):
                 'id': section_id,
                 'version': '',
             }
-            self.handle_panel_update(section_dict)
+            self.create_section(section_dict)
             tool_section = self._tool_panel[tool_panel_section_key]
             self._save_integrated_tool_panel()
         else:

test/unit/tools/test_toolbox.py

@@ -562,9 +562,6 @@ def __init__(self, test_case):
         # Need to start thread now for new reload callback to take effect
         self.app.watchers.start()
 
-    def handle_panel_update(self, section_dict):
-        self.create_section(section_dict)
-
 
 def reload_callback(test_case):
     test_case.app.tool_cache.cleanup()