Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in update_state! for DE.jl #98

Closed
jonathanfischer97 opened this issue Jan 20, 2024 · 2 comments
Closed

Typo in update_state! for DE.jl #98

jonathanfischer97 opened this issue Jan 20, 2024 · 2 comments

Comments

@jonathanfischer97
Copy link
Contributor

In the file DE.jl, there is a reference to F_max on line 96 which is not defined in the scope of update_state! and throws an error when DE is constructed with an F_max value. Here is the typo:

Typo

if parameters.F_min < parameters.F_max
    F = parameters.F_min + (F_max - parameters.F_min) * rand(rng)
end

Solution

if parameters.F_min < parameters.F_max
    F = parameters.F_min + (parameters.F_max - parameters.F_min) * rand(rng)
end
@mcamilletti1
Copy link
Contributor

Submitted a PR to fix this!

@jmejia8
Copy link
Owner

jmejia8 commented Jan 20, 2024

Thank you!

#100

Merged.

@jmejia8 jmejia8 closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants