Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL not updating after navigation jmix-framework/jmix#3654 #3875

Open
wants to merge 1 commit into
base: release_2_4
Choose a base branch
from
Open

URL not updating after navigation jmix-framework/jmix#3654 #3875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions jmix-flowui/flowui/src/main/java/io/jmix/flowui/view/navigation/RouteSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,12 @@ protected void updateQueryParameters(UI ui, String name, List<Object> values,
*/
public void setQueryParameters(UI ui, QueryParameters queryParameters) {
Page page = ui.getPage();
page.fetchCurrentURL(url -> {
log.debug("Fetched URL: {}", url.toString());

String locationString = resolveLocationString(url);
Location newLocation = new Location(locationString, queryParameters);
String locationString = getActiveViewLocation(ui).getPath();
Location newLocation = new Location(locationString, queryParameters);

log.debug("Replace URL state with new location: {}", newLocation.getPathWithQueryParameters());
page.getHistory().replaceState(null, newLocation, false);
});
log.debug("Replace URL state with new location: {}", newLocation.getPathWithQueryParameters());
page.getHistory().replaceState(null, newLocation);
}

/**
Expand Down