Refactor SMTP support to track sent emails and quotas #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all dependency version numbers to the workspace, as well as a few specific features.
I'm not sure why I thought that naming the crate after its dependency was a good idea in the first place, given that the use of lettre is an implementation detail. The abstractions in this create already use the Smtp prefix instead of Lettre, so renaming the crate seems fitting.
I'll soon be adding a database layer to this crate so moving the existing code into driver and model layers will help.
Modify the queue's get_result() and get_results_since() primitives to return tasks that failed on an earlier run and are scheduled to rerun later. This keeps all callers the same by making the client's wait() and wait_all() methods ignore retriable tasks until they are fully done. However, this adds a new wait_once() to wait for a task until it asks to retry or finishes, whichever happens first.
Introduce the SmtpDriver, which is a higher level mailer over another mailer that tracks how many messages have been sent so far and disallows exceeding a configured limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.