Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid redirects after saving and on navigation #424

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

jo-gross
Copy link
Owner

Closing issues:

Before you mark this PR as ready, please check the following points

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I´e created all necessary migrations?
  • The format is correct (pnpm format:check, if invalid pnpm format:fix)
  • No build errors (pnpm build)
  • I´ve tested the implemented function by my own
  • Ensure the pr title fits the conventional commit standard

Describe your work, what changed

I changed the general handling how to go back after editing an entity. The whole navigation should work now better.

Affected sites (please check during review):

  • all

Signed-off-by: Johannes Groß <mail@gross-johannes.de>
@jo-gross jo-gross linked an issue Sep 11, 2024 that may be closed by this pull request
1 task
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
@jo-gross jo-gross merged commit f1d2bd1 into main Sep 11, 2024
5 checks passed
@jo-gross jo-gross deleted the 423-bug-navigation-not-properly-working branch September 11, 2024 19:38
jg-semantic-release-bot bot pushed a commit that referenced this pull request Sep 11, 2024
## [1.9.1](v1.9.0...v1.9.1) (2024-09-11)

### Bug Fixes

* invalid redirects after saving and on navigation ([#424](#424)) ([f1d2bd1](f1d2bd1))
* not forcing background color on crop image ([92f077d](92f077d))
* Notes and description formating, new lines now displayed correctly ([b12fa7c](b12fa7c))
* restructured form layouts ([419cb7b](419cb7b))
@jg-semantic-release-bot
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Navigation not properly working
1 participant