Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated characters in leet speak transformer #76

Closed

Conversation

rion18
Copy link

@rion18 rion18 commented Aug 28, 2024

Type of change:

  • Refactor
  • Performance improvement
  • New feature
  • Bug fix
  • Other (please describe): Functionality improvement

Please describe the changes this PR makes and why it should be merged:
This MR updates some characters in the leet speak transformer, so it can detect profanities such as 5h1t, 5h!t, 0r645m and more.

Status:

  • I've added/modified unit tests relevant to my change / not needed
  • This PR contains breaking changes
  • This PR doesn't include changes to the code

@rion18 rion18 force-pushed the feature/added-characters-to-leet-resolver branch from 2507a70 to 7b38412 Compare August 28, 2024 18:07
@rion18 rion18 force-pushed the feature/added-characters-to-leet-resolver branch from 7b38412 to fd19424 Compare August 28, 2024 18:08
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (36b6512) to head (fd19424).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        26    -1     
  Lines          505       467   -38     
  Branches        92        80   -12     
=========================================
- Hits           505       467   -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jo3-l
Copy link
Owner

jo3-l commented Sep 1, 2024

Thanks for the PR. Would you mind rebasing and changing the target branch to dev instead of main? (Sorry this isn't made clear in the contribution guidelines.) If not, I'm happy to do it for you when I merge this change. FYI, I'm busy for the next month or so and a more thorough review and release will likely be delayed. You can of course use this updated transformer in your own code with the current version.

@rion18 rion18 closed this by deleting the head repository Sep 3, 2024
@rion18
Copy link
Author

rion18 commented Sep 3, 2024

Closed in favor of #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants