Skip to content

Commit

Permalink
Merge pull request #84 from joanhey/joanhey-patch-1
Browse files Browse the repository at this point in the history
Add PHP8.4 to tests
  • Loading branch information
joanhey authored Jan 8, 2025
2 parents a7c6159 + 1df918e commit d209346
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
php: ["8.1", "8.2", "8.3"]
php: ["8.1", "8.2", "8.3", "8.4"]

fail-fast: false

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"require-dev": {
"ext-curl": "*",
"pestphp/pest": "^2.8",
"mockery/mockery": "2.0.x-dev",
"mockery/mockery": "^1.6",
"guzzlehttp/guzzle": "^7.0"
},
"bin": ["adapterman"],
Expand Down
2 changes: 1 addition & 1 deletion src/functions/AdapterFunctions.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function header_remove(?string $name = null): void
*
* @link https://www.php.net/manual/en/function.http-response-code.php
*/
function http_response_code(int $code = null): int
function http_response_code(?int $code = null): int
{ // int|bool
return Http::responseCode($code); // Fix to return actual status when void
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Feature/GetTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
->toBeJson()
->json()
->toBe($data);
})->with([['complex array' => [
})->with([['complex_array' => [
'user' => [
'name' => 'Bob Smith',
'age' => '47',
Expand Down

0 comments on commit d209346

Please sign in to comment.