Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme with testing examples #409

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

pumano
Copy link
Contributor

@pumano pumano commented Aug 13, 2023

Added example about how to test whole form to readme

Connection with issue(s)

Solution description

Screenshots or Videos

To Do

  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@joanpablo
Copy link
Owner

Thanks @pumano

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2eef130) 95.62% compared to head (bb15338) 95.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files          66       66           
  Lines        1348     1348           
=======================================
  Hits         1289     1289           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pumano
Copy link
Contributor Author

pumano commented Aug 13, 2023

I updated recently with Validators.email

@pumano
Copy link
Contributor Author

pumano commented Aug 13, 2023

@joanpablo thank you for amazing library. I got perfect angular experience here :)

@joanpablo
Copy link
Owner

@joanpablo thank you for amazing library. I got perfect angular experience here :)

Thanks @pumano for your kind words.

@joanpablo joanpablo merged commit 59bf100 into joanpablo:master Aug 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants