Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing context menu in ReactiveTextField #416

Closed

Conversation

victorcatn
Copy link
Contributor

Connection with issue(s)

Close #398

Solution description

copied the default _defaultContextMenuBuilder from vanilla Flutter TextField to ReactiveTextField to keep the same behaviour

Screenshots or Videos

To Do

  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (12f2172) 95.72% compared to head (d2ed55b) 95.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   95.72%   95.58%   -0.15%     
==========================================
  Files          66       66              
  Lines        1357     1359       +2     
==========================================
  Hits         1299     1299              
- Misses         58       60       +2     
Files Coverage Δ
lib/src/widgets/reactive_text_field.dart 93.18% <0.00%> (-4.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matecode
Copy link

matecode commented Oct 20, 2023

Hi @victorcatn ! Any chance this pr comes soon to production?

@joanpablo
Copy link
Owner

Hi @victorcatn
Thanks for the PR. I will take a look at it. Is there a way to add a test to maintain the same coverage percentage?

@joanpablo
Copy link
Owner

Hi everyone, thanks once again for the support. I have released version 16.1.1 which fixes this issue. Please give it a look and don't hesitate to create a new issue or PR is something else is missing.

@joanpablo joanpablo closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contextMenuBuilder not enable by default,
3 participants