Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce intl constraint to match flutter_localizations 3.16.0 #448

Merged
merged 1 commit into from
May 10, 2024

Conversation

kuhnroyal
Copy link
Contributor

@kuhnroyal kuhnroyal commented Apr 26, 2024

Connection with issue(s)

See 839968f#r141272235

The flutter_localizations package from Flutter SDK 3.16.0 forces intl: 0.18.1 - see https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_localizations/pubspec.yaml#L11

Solution description

I reduced the constraint and added the flutter_localizations package as additional dependency to ensure this does not happen again. This should have no impact on consumers of the package as the Flutter SDK is already required.

Screenshots or Videos

To Do

  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (1a3c954) to head (827c895).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #448   +/-   ##
========================================
  Coverage    95.01%   95.01%           
========================================
  Files           67       67           
  Lines         1385     1385           
========================================
  Hits          1316     1316           
  Misses          69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanpablo
Copy link
Owner

joanpablo commented May 9, 2024

Hey @kuhnroyal
Thanks for the PR, but would you mind to remove the dependency to flutter_localizations and just lower the intl version? Thanks in advance

@kuhnroyal
Copy link
Contributor Author

I added that explicitly to prevent the same problem in the future. This has zero impact on users of the reactive_forms as it is an SDK dependency which does not have to be downloaded and will get tree-shaken if not used.

If you still want me to remove it, let me know.

@joanpablo joanpablo merged commit 9fd5c6c into joanpablo:develop May 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants