Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #20 #21

Closed
wants to merge 2 commits into from
Closed

Issue #20 #21

wants to merge 2 commits into from

Conversation

Timoniche
Copy link
Contributor

Hello! There were maintaining tokens points in this issue. So far I added field and handled it, which tokens aka {datetime} do u like to add?

@joelmccracken
Copy link
Owner

So, my initial thought when I saw this feature request was "just add a custom handler" and then use bash to define what the current datetime is.

So the (partial) config would be:

handlers:
  git:
    commands:
      - name: WIP with (d)ate
        cmd: git add -a ; git commit -m "WIP $(date)"
        key: d

... and then we might add this to the "library" of potential other handlers. The downside here is that the original WIP commit option will still be there.

I wonder, would it be better to allow for "overriding" commands with hotkeys? so if you specify the same key/name, the default ones provided "disappear" from the menu, and instead it would show yours?

Thoughts @dariooddenino, especially re: #20?

IMO, Ideally we would steer people towards defining custom handlers whenever practical instead of adding "tweaks" to the data model here.

@dariooddenino
Copy link

I think overriding would be good.

@joelmccracken
Copy link
Owner

this is OBE #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants