Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated code snippet for property traversal #258

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ricekot
Copy link
Contributor

@ricekot ricekot commented Sep 19, 2024

The code snippet generated with FilterSteps#genericOption results in an error like the one below during compilation.

value || is not a member of Iterable[Long @uncheckedVariance]

Replacing .empty with .isEmpty should fix this.

The code snippet generated with `FilterSteps#genericOption` results in an error
like the one below during compilation.

```
value || is not a member of Iterable[Long @uncheckedVariance]
```

Replacing `.empty` with `.isEmpty` should fix this.

Signed-off-by: ricekot <git@ricekot.com>
@mpollmeier
Copy link
Contributor

Sorry for not noticing this, I didn't have notifications on for this repo :(
Thank you for the PR, I'll be on this shortly.

@mpollmeier mpollmeier merged commit ab93c28 into joernio:master Sep 26, 2024
1 check passed
@ricekot ricekot deleted the fix-codesnippet branch September 26, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants