Replace javasrc2cpg ReflectionTypeSolver with JdkJarTypeSolver at java home #3006
Conversation
| combinedTypeSolver.add(new CachingReflectionTypeSolver()) | ||
| val jdkPath = config.jdkPath.getOrElse { | ||
| val javaHome = System.getProperty("java.home") | ||
| logger.debug("No explicit jdkPath set in config, so using system java.home at $javaHome") |
There was a problem hiding this comment.
That is definitely worth logging as INFO
| } | ||
| } | ||
|
|
||
| enum JavaSrcEnvVar(val name: String, val description: String) { |
There was a problem hiding this comment.
This is perhaps excessive for a single environment variabl, but I also think that, if environment variables are going to be used for configuration, they should be documented somehow and easily discoverable. I plan to extend this idea to the rest of joern (I know at least php2cpg uses some environment variables as well), but put this here since it's currently limited to javasrc.
|
Unit tests are running into |
| // This should really be a print-and-exit but, with the current scopt setup, input paths | ||
| // are still required, so for now `javasrc2cpg --show-env <inputs>` is less confusing | ||
| // than `javasrc2cpg --show-env <dummy input to keep scopt happy>` | ||
| .text("print information about environment variables used by javasrc2cpg prior to analysis") |
There was a problem hiding this comment.
Add to the comment that this prevents the frontend from doing its actual task.
|
Running just the |
johannescoetzee
force-pushed
the
johannes/jdk-type-solver-by-default
branch
2 times, most recently
from
76cadb7
to
700fe37
Compare
Running tests from different subprojects in parallel seems to bring us to the limits...
johannescoetzee
force-pushed
the
johannes/jdk-type-solver-by-default
branch
from
3bb01e4
to
cacd5cf
Compare
Using the
ReflectionTypeSolverand theJdkJarTypeSolverwith jars from the current runtime java home give similar, but not identical results. This is problematic for getting consistent results, particularly when updating expectations for SP tests. This PR switches to theJdkJarTypeSolveras the single "java stdlib" type solver for the sake of consistency.