GoSrc2Cpg : AST generation for switch case #3018
Conversation
README.md
Outdated
| @@ -1,5 +1,5 @@ | |||
| Joern - The Bug Hunter's Workbench | |||
| === | |||
| === | |||
There was a problem hiding this comment.
random Js test case was failing, so this space was to retrigger checks
There was a problem hiding this comment.
I think this should be removed, it pollutes the diff
There was a problem hiding this comment.
ok, removing this
| @@ -100,7 +107,7 @@ trait AstForStatementsCreator { this: AstCreator => | |||
| private def astForConditionExpression(condStmt: ParserNodeInfo): Ast = { | |||
| condStmt.node match { | |||
| case ParenExpr => astForNode(condStmt.json(ParserKeys.X)).head | |||
| case _ => Ast() | |||
| case _ => astsForStatement(condStmt).head | |||
There was a problem hiding this comment.
Please guarantee that astForStatement(condStmt) is always non-empty to avoid NoSuchElementException here.
There was a problem hiding this comment.
Yes, will take that precaution
README.md
Outdated
| @@ -1,5 +1,5 @@ | |||
| Joern - The Bug Hunter's Workbench | |||
| === | |||
| === | |||
There was a problem hiding this comment.
I think this should be removed, it pollutes the diff
| @@ -100,7 +107,7 @@ trait AstForStatementsCreator { this: AstCreator => | |||
| private def astForConditionExpression(condStmt: ParserNodeInfo): Ast = { | |||
| condStmt.node match { | |||
| case ParenExpr => astForNode(condStmt.json(ParserKeys.X)).head | |||
| case _ => Ast() | |||
| case _ => astsForStatement(condStmt).head | |||
There was a problem hiding this comment.
| case _ => astsForStatement(condStmt).head | |
| case _ => astsForStatement(condStmt).headOption.getOrElse(Ast()) |
There was a problem hiding this comment.
@DavidBakerEffendi Have made the suggested changes
|
@khemrajrathore take the latest updates from the master and lets get this merged |
|
@DavidBakerEffendi Can we get this merged? |
The PR covers the following
localnode in the condition of switch it throws an error