-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rubysrc2cpg]: Move ImportResolverPass to PostProcessingPasses #3091
[rubysrc2cpg]: Move ImportResolverPass to PostProcessingPasses #3091
Conversation
new MetaDataPass(cpg, Languages.RUBYSRC, config.inputPath).createAndApply() | ||
new ConfigFileCreationPass(cpg).createAndApply() | ||
if (config.enableDependencyDownload && !scala.util.Properties.isWin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely we can keep this code? I would recommend adding val packageTableInfo = new PackageTable()
as a field to RubySrc2Cpg
which can then later be given to the post-processing passes to use.
This way we can still run AstCreationPass
with downloaded dependency info without forcing us to run the rest of the enhancements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, Check now @DavidBakerEffendi
No description provided.