Fine-Tune Type Prop Queries & Added Iterations CLI Opt #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optimized queries and data structures here and there, was able to reduce the memory consumption but it only defers a huge allocation later. * Added CLI opt for JS and Python `--type-prop-iterations` where one can set how many type propagation iterations run. 2 onwards typically involves interprocedural propagation. e.g. `./joern-parse .../../Workspace/test-repos/python/open-mmlab --frontend-args --type-prop-iterations 1` finishes for me but only performs intraprocedural type propagation. @yzn12345 The type propagation is pretty rough around the edges and likely can be rewritten to be a bit more precise and performant but I hope this helps generate python CPGs with some type recovery! Somewhat resolves #3211
DavidBakerEffendi
added
bug
|
Can we error out (or at least show a warning) if someone enters an invalid value for |
* Added `TypeRecoveryParserConfig` and `XTypeRecovery.parserOptions` to reduce code duplication across frontends that use type propagation * Added logger info/warnings for type propagation iteration count, but no failures
|
@max-leuthaeuser I've made a type propagation config trait and re-usable |
max-leuthaeuser
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--type-prop-iterationswhere one can set how many type propagation iterations run. 2 onwards typically involves interprocedural propagation. e.g../joern-parse .../../Workspace/test-repos/python/open-mmlab --frontend-args --type-prop-iterations 1finishes for me but only performs intraprocedural type propagation.@yzn12345 The type propagation is pretty rough around the edges and likely can be rewritten to be a bit more precise and performant but I hope this helps generate python CPGs with some type recovery!
Somewhat resolves #3211