Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rubysrc2cpg] Decouple parser and ASTCreator #3283

Merged
merged 4 commits into from
Jul 28, 2023
Merged

[rubysrc2cpg] Decouple parser and ASTCreator #3283

merged 4 commits into from
Jul 28, 2023

Conversation

fabsx00
Copy link
Contributor

@fabsx00 fabsx00 commented Jul 27, 2023 •
edited
Loading

  • Fix a bug in command line parsing (when flag was enabled by user, flag was disabled in the config)
  • Catch parser errors inside createAst and skip the corresponding file rather than failing

I'm still tuning the logging a bit so that we get actionable information.

@fabsx00 fabsx00 requested a review from xavierpinho July 27, 2023 09:01
@fabsx00 fabsx00 merged commit cacae03 into master Jul 28, 2023
5 checks passed
@max-leuthaeuser max-leuthaeuser deleted the fabs/rubychanges branch August 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierpinho xavierpinho xavierpinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabsx00 @xavierpinho