[rubysrc2cpg] Enhancing TypeDecl implementation #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emraj/methodAndCallInSameFile
…emraj/methodAndCallInSameFile
…emraj/methodAndCallInSameFile
…emraj/fixingClassInstanceCalls
DavidBakerEffendi
requested changes
Aug 1, 2023
| @@ -36,6 +86,10 @@ trait AstCreatorHelper { this: AstCreator => | |||
| usedVariableNames.put(variableName, counter) | |||
| currentVariableName | |||
| } | |||
|
|
|||
| protected def addReceiverEdge(dstNode: nodes.NewNode, srcNode: nodes.NewNode): Unit = { | |||
There was a problem hiding this comment.
Something like this exists in the Ast() class already
There was a problem hiding this comment.
Will remove this code as anyways we are not using this function anywhere in ruby
| case _: SimpleMethodNamePartContext if !classStack.top.endsWith(":program") => | ||
| val thisParameterNode = createMethodParameterIn( | ||
| "this", | ||
| typeFullName = callNode.methodFullName, |
There was a problem hiding this comment.
Does this call node refer to the :program method?
There was a problem hiding this comment.
No, the call node refers to methodDefinition. We use the information from the callNode and discard it
Basically here for any methodDefinition encountered we are categorizing the whether they are class method or instance method
DavidBakerEffendi
changed the title
DavidBakerEffendi
added
enhancement
…emraj/fixingClassInstanceCalls
|
@DavidBakerEffendi Have made the requested changes |
DavidBakerEffendi
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains the following
thisparameter as the parameter with index 0, which help in tracking and linking dataflow for instance variablesindexandordervaluescc - @fabsx00 @DavidBakerEffendi