-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rubysrc2cpg] Enhancing TypeDecl implementation #3358
Merged
DavidBakerEffendi
merged 12 commits into
joernio:master
from
Privado-Inc:khemraj/fixingClassInstanceCalls
Aug 2, 2023
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2656042
remove the logic to treat anything uppercase as Constant member
khemrajrathore 40d2c12
Merge branch 'master' of https://github.com/Privado-Inc/joern into kh…
khemrajrathore 95c5824
add - dummy assignment nodes for builtins and method definitions
khemrajrathore 4dda0b8
Merge branch 'master' of https://github.com/Privado-Inc/joern into kh…
khemrajrathore 6fa1196
Merge branch 'master' of https://github.com/Privado-Inc/joern into kh…
khemrajrathore 858c587
merged
khemrajrathore 763e4d1
Merge branch 'khemraj/methodAndCallInSameFile' into khemraj/fixingCla…
khemrajrathore 08b5f49
remove dummy test case
khemrajrathore 7d8373d
Merge branch 'master' of https://github.com/Privado-Inc/joern into kh…
khemrajrathore 772fb4d
Merge branch 'master' of https://github.com/Privado-Inc/joern into kh…
khemrajrathore fd87195
scalafmt
khemrajrathore 11e24ff
removed unused method
khemrajrathore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this call node refer to the
:program
method?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the call node refers to methodDefinition. We use the information from the callNode and discard it
Basically here for any methodDefinition encountered we are categorizing the whether they are class method or instance method