-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruby_ast_gen] Control Structures #5008
Merged
DavidBakerEffendi
merged 23 commits into
andrei/ruby/ruby_ast_gen_json
from
dave/ruby/ruby_ast_gen
Oct 17, 2024
Merged
[ruby_ast_gen] Control Structures #5008
DavidBakerEffendi
merged 23 commits into
andrei/ruby/ruby_ast_gen_json
from
dave/ruby/ruby_ast_gen
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h DownloadHelper's assumptions on ensuring files are available.
* Handle initial class/module body creation & summary creation * Separated tests between versions
* Improved runner stability and handling class fields * [ruby_ast_gen] Handling for Singleton & Anon Classes Additionally, added handling for range operators and lowered hash arguments in calls to named arguments to be consistent with current ANTLR interpretation of these args. * Roll back AstGenRunner changes * Remove line for diff
DavidBakerEffendi
changed the title
[ruby] JSON Ast Gen
[ruby_ast_gen] Control Structures
Oct 17, 2024
DavidBakerEffendi
approved these changes
Oct 17, 2024
DavidBakerEffendi
merged commit Oct 17, 2024
afa1556
into
andrei/ruby/ruby_ast_gen_json
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling for all control structures using JSON AST. Added tests to
json/ControlStructureTests
based on old ANTLR tests