use the '__iter__' attribute to determine if something is iterable vs a volatile error message #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth2 uses the error string 'is not iterable' after try to cast to a list:
https://github.com/simplegeo/python-oauth2/blob/master/oauth2/__init__.py#L135
This is a fragile way of determining if something is an iterable or not. Instead, the 'iter' attribute can be checked for.
As a case in point, for python 2.4 the error message is:
See https://bugzilla.mozilla.org/show_bug.cgi?id=789972#c12 which is the motivation for this pull request