Adds a keyword argument for explicitly setting the realm parameter for an OAuth Authorization header #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uests OAuth Authorization header. Useful in case an OAuth implementation incorrectly rejects the auto-constructed realm.
|
Hello! Is anyone still monitoring this repo? |
|
I don't think anyone is. I need this patch too. Just gunna fork. |
|
Ahoy, we are attempting to get this maintained. Got someone to transfer it to @jaitaiwan and I. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My need for this specifically came up because the OAuth implementation for the QuickBooks Online API rejects a realm of "https://qbo.sbfinance.intuit.com" ('WWW-Authenticate: OAuth oauth_problem="parameter_rejected", oauth_parameters_rejected="realm"') as auto-constructed from a request to "https://qbo.sbfinance.intuit.com/resource/customer..." but accepts a realm of "qbo.sbfinance.intuit.com".
As this override option is implemented as a keyword argument with a default, the revised version of the library should be wholly backward-compatible.
Best,
Jon