outputHeightRatio not defined error!

[mehulkaklotar]

when using npm package, getting this

npm package has this error here

there is a variable define error. i think need to update the croppie lib here.

[jofftiquez]

Hi @mehulkaklotar thanks for reporting this. I'll investigate this as soon as possible. For the meantime, can you kindly create a reproduction link please? Thanks.

[mehulkaklotar]

@jofftiquez there is a issue in code dist lib. see here https://github.com/jofftiquez/vue-croppie/blob/master/dist/index.js#L1383. outputHeightRatio is not defined because it has no var because outputWidthRatio has ; with it.

[jofftiquez]

@mehulkaklotar This is actually from the official Croppie code base. See https://github.com/Foliotek/Croppie/blob/master/croppie.js#L1162. I'll talk to the author tho. Thanks for pointing it out.

[mehulkaklotar]

@jofftiquez do you have update on this?

[jofftiquez]

@mehulkaklotar hello. I am sorry, but so far I haven't got any response from Croppie itself. :(

[gregurco]

@jofftiquez could you please review and merge #32?

[jofftiquez]

@gregurco Thanks! Am still thinking if I will merge #32 coz am planning to update this repo to Croppie's latest version anyways. I'll review it again.

[tshafer]

Any update on this?