Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aircraft): improve aircraft data #21

Merged

Conversation

chris-pryazhentsev
Copy link
Contributor

  • Sorted Aircraft by name
  • Removed duplicated aircraft types
  • Added more specific model types where it made sense (ex. Added 737-200/300/400/500/600/900, not random subtypes such as MAX 8200)
  • Removed non-existent aircraft types such as Avro ARX
  • Fixed AN-225 Weight Class from L to J
  • Other general improvements to aircraft.ts

@github-actions github-actions bot added the web label Sep 13, 2024
@johanohly johanohly changed the title pryazhentsev/aircraft data cleanup feat(aircraft): improve aircraft data Sep 14, 2024
@johanohly
Copy link
Owner

Thank you very much for doing this!

I noticed that these ICAO codes are no longer present, which would lead to possible data-loss if someone had selected one of those airplanes.
"E75S", "E75L", "A330", "RX1H", "EMB1", "EMB4", "EMB7", "A350", "A380", "B747", "B767", "B777", "B787", "AN124", "AN225"
Please ensure no ICAO codes are removed except for a very good reason.

I also noticed that these three codes are duplicated
A306, AT75 and B763

@johanohly johanohly self-assigned this Oct 6, 2024
@johanohly johanohly merged commit d3e5610 into johanohly:main Oct 6, 2024
3 checks passed
@johanohly
Copy link
Owner

Thank you again for doing this. I did realise that most of the codes you removed were not valid ICAO codes (not sure how that happened), so I kept most of your removals but added a migration script to ensure no data loss will happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants