Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Extraction for .it.com Domains #328

Open
adam-sav opened this issue Mar 27, 2024 · 3 comments
Open

Incorrect Extraction for .it.com Domains #328

adam-sav opened this issue Mar 27, 2024 · 3 comments

Comments

@adam-sav
Copy link

I've noticed an issue attempting to use tldextract.extract on domains like test.it.com and test.ru.com where it treats the actual sld of "test" as a subdomain and "it" and "ru" as the sld with a tld of "com". Upon looking at the list TLDExtract draws from, however, I see that both tlds are there. It would be helpful if a change was made that allowed for the tlds like it.com, ru.com, sa.com, and za.com to be interpreted correctly. Let me know if you have any questions about this issue. Thank you.

@john-kurkowski
Copy link
Owner

See this FAQ entry.

@elliotwutingfeng
Copy link
Contributor

@john-kurkowski perhaps we should pin an issue linking to the "Public vs. private domains" section?

@john-kurkowski
Copy link
Owner

I like that idea! I think I've seen other projects do that, but never tried it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants